On 01/11/2017 03:17 AM, Richard Henderson wrote: > This lets us expose facilities to TCG_TARGET_HAS_* defines > directly, rather than hiding behind function calls. > > Signed-off-by: Richard Henderson <r...@twiddle.net> > --- > tcg/s390/tcg-target.h | 126 > ++++++++++++++++++++++++---------------------- > tcg/s390/tcg-target.inc.c | 74 +++++++++++---------------- > 2 files changed, 96 insertions(+), 104 deletions(-)
This broke compilation.Seems that you forgot one replacement: In file included from /home/cborntra/REPOS/qemu/tcg/tcg.c:253:0: /home/cborntra/REPOS/qemu/tcg/s390/tcg-target.inc.c: In function ‘tgen_cmp’: /home/cborntra/REPOS/qemu/tcg/s390/tcg-target.inc.c:1096:19: error: ‘facilities’ undeclared (first use in this function) if (!(facilities & FACILITY_EXT_IMM)) { ^~~~~~~~~~ /home/cborntra/REPOS/qemu/tcg/s390/tcg-target.inc.c:1096:19: note: each undeclared identifier is reported only once for each function it appears in /home/cborntra/REPOS/qemu/rules.mak:64: recipe for target 'tcg/tcg.o' failed make[1]: *** [tcg/tcg.o] Error 1 Makefile:203: recipe for target 'subdir-s390x-softmmu' failed make: *** [subdir-s390x-softmmu] Error 2 make: Leaving directory '/home/cborntra/REPOS/qemu/build'