On 01/11/2017 11:29 AM, Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > chardev/char-win.h | 30 ++++++ > chardev/char-win.c | 242 +++++++++++++++++++++++++++++++++++++++++++++++ > chardev/char.c | 253 > +------------------------------------------------- > chardev/Makefile.objs | 1 + > 4 files changed, 276 insertions(+), 250 deletions(-) > create mode 100644 chardev/char-win.h > create mode 100644 chardev/char-win.c >
> +++ b/chardev/Makefile.objs > @@ -4,3 +4,4 @@ chardev-obj-y += char-io.o > chardev-obj-y += char-mux.o > chardev-obj-y += char-null.o > chardev-obj-y += char-ringbuf.o > +chardev-obj-$(CONFIG_WIN32) += char-win.o This part is the neatest - trading #ifdefs in the code for conditionally compiling an entire .c file. I have not closely read 28-39, so I don't know if R-b is appropriate, but they are all mechanical and the fact that it still compiles is good. So maybe we go with the weaker: Acked-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
