On 18.01.2017 04:22, Ziyue Yang wrote: > From: Ziyue Yang <yzyliv...@hotmail.com> > > Some updates from fprintf(stderr, ...) to error_report. > > Signed-off-by: Ziyue Yang <skiver.cloud....@gmail.com> > --- > gdbstub.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/gdbstub.c b/gdbstub.c > index 426d55e..fe1d0f8 100644 > --- a/gdbstub.c > +++ b/gdbstub.c > @@ -637,8 +637,8 @@ void gdb_register_coprocessor(CPUState *cpu, > *p = s; > if (g_pos) { > if (g_pos != s->base_reg) { > - fprintf(stderr, "Error: Bad gdb register numbering for '%s'\n" > - "Expected %d got %d\n", xml, g_pos, s->base_reg); > + error_report("Error: Bad gdb register numbering for '%s', " > + "Expected %d got %d", xml, g_pos, s->base_reg);
Since the message is now printed in one line with a comma in between, I'd maybe rather write "expected" without capital letter. Thomas