On Wed, 18 Jan 2017 22:55:40 +0200 "Michael S. Tsirkin" <m...@redhat.com> wrote:
> Coverity reports that ARRAY_SIZE(elem->out_sg) (and all the others too) > is wrong because elem->out_sg is a pointer. > > However, the check is not in the right place and the max_size argument > of virtqueue_map_iovec can be removed. The check on in_num/out_num > should be moved to qemu_get_virtqueue_element instead, before the call > to virtqueue_alloc_element. > > Cc: qemu-sta...@nongnu.org > Reported-by: Paolo Bonzini <pbonz...@redhat.com> > Fixes: 3724650db07057333879484c8bc7d900b5c1bf8e ("virtio: introduce > virtqueue_alloc_element") > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > --- > hw/virtio/virtio.c | 33 +++++++++++++-------------------- > 1 file changed, 13 insertions(+), 20 deletions(-) Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com>