On 01/25/17 02:43, b...@skyportsystems.com wrote: > From: Ben Warren <b...@skyportsystems.com> > > This allows pc_i440fx-based machines to add new devices such as VM Generation > ID > directly to the sysbus. > > Signed-off-by: Ben Warren <b...@skyportsystems.com> > --- > hw/i386/pc_piix.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index 9f102aa..c8ad99c 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -435,6 +435,7 @@ static void pc_i440fx_machine_options(MachineClass *m) > m->hot_add_cpu = pc_hot_add_cpu; > m->default_machine_opts = "firmware=bios-256k.bin"; > m->default_display = "std"; > + m->has_dynamic_sysbus = true; > } > > static void pc_i440fx_2_9_machine_options(MachineClass *m) >
Looks reasonable to me, especially that Q35 already sets it. One nit: please wrap the commit message at 74 chars. I'll let others review the rest of the patches. (My interest lies in the ACPI & fw_cfg bits.) Thanks! Laszlo
