On Wed, Jan 25, 2017 at 07:24:03PM +0000, Peter Maydell wrote: > On 25 January 2017 at 18:08, Peter Maydell <peter.mayd...@linaro.org> wrote: > > On 25 January 2017 at 18:02, Marcel Apfelbaum > > <marcel.apfelb...@gmail.com> wrote: > >> Strange, I re-based in the same day I posted and compiled just fine... > >> However, I get the same error using today's master. > >> > >> I'll fix and re-post the series. > > > > mst has done a rebase of the pull request which I'll retry later. > > Results: > /home/petmay01/linaro/qemu-for-merges/hw/display/qxl.c: In function > ‘qxl_rom_size’: > /home/petmay01/linaro/qemu-for-merges/hw/display/qxl.c:313:20: error: > bit-field ‘<anonymous>’ width not an integer constant > QEMU_BUILD_BUG_ON(required_rom_size > rom_size); > ^ > > x86-64 linux host; I guess the usage in this file conflicts > with your series' rephrasing of the macro for some versions > of gcc. This is gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
I guess what happened previously is that gcc did not actually check this size at all. I posted a patch to rewrite using macros. Trivial but I still will give maintainer a bit of time to take a look. > If I rewrite the build-assert in qxl.c as > QEMU_BUILD_BUG_ON(sizeof(QXLRom) + sizeof(QXLModes) + > sizeof(qxl_modes) > 8192); > it compiles OK (and the build then runs into the error below). > > > All the other build hosts fell over like this: > > /home/pm215/qemu/hw/pci-bridge/gen_pcie_root_port.c:54:9: error: > implicit declaration of function ‘VMSTATE_PCIE_DEVICE’ > [-Werror=implicit-function-declaration] > VMSTATE_PCIE_DEVICE(parent_obj.parent_obj.parent_obj, PCIESlot), > ^ > /home/pm215/qemu/hw/pci-bridge/gen_pcie_root_port.c:54:29: error: > ‘parent_obj’ undeclared here (not in a function) > VMSTATE_PCIE_DEVICE(parent_obj.parent_obj.parent_obj, PCIESlot), > ^ > /home/pm215/qemu/hw/pci-bridge/gen_pcie_root_port.c:54:63: error: > expected expression before ‘PCIESlot’ > VMSTATE_PCIE_DEVICE(parent_obj.parent_obj.parent_obj, PCIESlot), > > thanks > -- PMM