I don't like "change FOO" subject lines. What about; qapi: Simplify qapi2texi.py a bit
This way, it's obvious that the commit isn't supposed to change behavior. Can touch up on commit. Marc-André Lureau <marcandre.lur...@redhat.com> writes: > STRUCT_FMT is generic enough, rename it to TYPE_FMT, use it for unions. > > Rename COMMAND_FMT to MSG_FMT, since it applies to both commands and > events. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > scripts/qapi2texi.py | 46 +++++++++++++++++++--------------------------- > 1 file changed, 19 insertions(+), 27 deletions(-) > > diff --git a/scripts/qapi2texi.py b/scripts/qapi2texi.py > index 83ded95c2d..e1b79c2ad3 100755 > --- a/scripts/qapi2texi.py > +++ b/scripts/qapi2texi.py > @@ -9,7 +9,7 @@ import sys > > import qapi > > -COMMAND_FMT = """ > +MSG_FMT = """ QMP_MSG_FMT? Your choice, can rename on commit. > @deftypefn {type} {{}} {name} > > {body} [...] With the commit message improved: Reviewed-by: Markus Armbruster <arm...@redhat.com>