Lluís Vilanova writes: > Richard Henderson writes: >> On 01/13/2017 12:48 PM, Lluís Vilanova wrote: >>> @@ -237,7 +237,7 @@ char *trace_opt_parse(const char *optarg); >>> * >>> * Return the number of known vcpu-specific events >>> */ >>> -uint32_t trace_get_vcpu_event_count(void); >>> +static uint32_t trace_get_vcpu_event_count(void); >>>
>> Why is this declaration still here? It's redundant with the inline. > I can remove it if you feel strongly against it, but I kept it to maintain > consistency with the rest of the file. As I said in the previous series, this > is > the style used in the header. All "public" functions (inlined or not) are > declared there with their documentation. > Being inlined is an implementation detail (inlines are defined on a separate > header), but given C's design it leaks through the static declaration. Ping. Cheers, Lluis
