On Wed, Feb 01, 2017 at 11:41:40PM -0800, no-re...@patchew.org wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Type: series > Subject: [Qemu-devel] [PULL 000/107] ppc-for-2.9 queue 20170202 > Message-id: 20170202051445.5735-1-da...@gibson.dropbear.id.au > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > # Useful git options > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; > then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > * [new tag] > patchew/20170202051445.5735-1-da...@gibson.dropbear.id.au -> > patchew/20170202051445.5735-1-da...@gibson.dropbear.id.au > Switched to a new branch 'test' [snip] > Checking PATCH 46/107: target-ppc: Add xxextractuw instruction... > ERROR: Macros with complex values should be enclosed in parenthesis > #110: FILE: target/ppc/translate/vsx-ops.inc.c:52: > +#define GEN_XX2FORM_EXT(name, opc2, opc3, fl2) \ > +GEN_HANDLER2_E(name, #name, 0x3C, opc2 | 0, opc3, 0x00100000, PPC_NONE, > fl2), \ > +GEN_HANDLER2_E(name, #name, 0x3C, opc2 | 1, opc3, 0x00100000, PPC_NONE, fl2) > > total: 1 errors, 0 warnings, 92 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS.
This one is a standard false positive due to checkpatch being confused by the ugly macros in this file. [snip] > Checking PATCH 93/107: target/ppc: Add pcr_supported to POWER9 cpu class > definition... > ERROR: spaces required around that '-' (ctx:VxV) > #22: FILE: target/ppc/cpu.h:2293: > + PCR_COMPAT_3_00 = 1ull << (63-59), > ^ > > total: 1 errors, 0 warnings, 15 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. This one's matching the surrounding code which is already not quite in style, best to fix those together sometime later. [snip] > Checking PATCH 100/107: target-ppc: Add xvtstdc[sp, dp] instructions... > ERROR: Macros with complex values should be enclosed in parenthesis > #126: FILE: target/ppc/translate/vsx-ops.inc.c:137: > +#define GEN_XX2FORM_DCMX(name, opc2, opc3, fl2) \ > +GEN_XX3FORM(name, opc2, opc3 | 0, fl2), \ > +GEN_XX3FORM(name, opc2, opc3 | 1, fl2) > > total: 1 errors, 0 warnings, 96 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. This one's the false positive again. [snip] > Checking PATCH 103/107: tcg/POWER9: NOOP the cp_abort instruction... > ERROR: do not use C99 // comments > #28: FILE: target/ppc/translate.c:6025: > + // Do Nothing > > total: 1 errors, 0 warnings, 17 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. But this one was me being sloppy. Do we care enough to re-do the pullreq? -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature