Loïc Minier <loic.min...@linaro.org> writes: > When configure runs "exit 1", the trap handler is run to cleanup any > files created by configure, but this trap handler itself calls "exit" > with no argument (which means zero exit code): > [...] > + echo Error: zlib check failed > Error: zlib check failed > + echo Make sure to have the zlib libs and headers installed. > Make sure to have the zlib libs and headers installed. > + echo > > + exit 1 > + rm -f /tmp/qemu-conf--2779-.c /tmp/qemu-conf--2779-.o > /tmp/qemu-conf--2779-.exe > + exit > > To fix this, remove the call to exit from the trap handler, leaving it > to the shell shell to exitafter the trap handler is run (honoring any > previously provided exit code).
This suggests the old code screws up the exit code. It doesn't for me. Unless it does at least on some platforms, it's a cleanup, not a fix, and the commit message should reflect that.
