On 2017年01月24日 22:05, zhanghailiang wrote:
The original 'timer_check_lock' mutex lock of struct CompareState is used to protect the 'conn_list' queue and its child queues which are 'primary_list' and 'secondary_list', which is a little abused and confusing To make it clearer, we rename 'timer_check_lock' to 'conn_list_lock' which is used to protect 'conn_list' queue, use another 'conn_lock' to protect 'primary_list' and 'secondary_list'. Besides, fix some missing places which need these mutex lock. Signed-off-by: zhanghailiang<zhang.zhanghaili...@huawei.com>
Instead of sticking to such kind of mutex, I think it's time to make colo timer run in colo thread (there's a TODO in the code).
Thought? Thanks
