On 25 January 2017 at 07:38, Alessandro Di Federico <ale+q...@clearmind.me> wrote: > On Tue, 24 Jan 2017 11:18:07 +0000 > Peter Maydell <peter.mayd...@linaro.org> wrote: >> If we had more active testing of bsd-user I'd be a bit keener >> about removing some of the code duplication. > > Currently, the code looks exactly the same to me. If we don't factor it > out I'll have to make a third copy of it for libtcg, which is kinda > annoying. I'm factoring out only a portion of the header, which > probably doesn't change that much. If in the future there's some change > we're not sure about we can keep it in the non-factored out part.
OK, fair enough. Regarding whether the linux-* and bsd-* put_user are equivalent, they should be; it's just that bsd-* doesn't get fixes that we make to linux-* because it's unmaintained code. thanks -- PMM
