On Tue, Jan 31, 2017 at 4:24 AM, P J P <ppan...@redhat.com> wrote:
> From: Prasad J Pandit <p...@fedoraproject.org>
>
> In SDHCI device emulation the 'Block count enable' bit
Can you say 'In the SDHCI protocol' instead of 'SDHCI device emulation'?
I feel like saying device emulation makes it sound like we are
behaving different then hardware.
Also maybe the title should be something more like:
sd: sdhci: Remove block count enable check in single block transfers
to make it clearer.
> of the Transfer Mode register is only relevant in multi block
> transfers. We need not check it in single block transfers.
>
> Signed-off-by: Prasad J Pandit <p...@fedoraproject.org>
The functionality looks good to me.
Reviewed-by: Alistair Francis <alistair.fran...@xilinx.com>
Thanks,
Alistair
> ---
> hw/sd/sdhci.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
> index 150464f..d921423 100644
> --- a/hw/sd/sdhci.c
> +++ b/hw/sd/sdhci.c
> @@ -570,7 +570,6 @@ static void sdhci_sdma_transfer_multi_blocks(SDHCIState
> *s)
> }
>
> /* single block SDMA transfer */
> -
> static void sdhci_sdma_transfer_single_block(SDHCIState *s)
> {
> int n;
> @@ -589,10 +588,7 @@ static void sdhci_sdma_transfer_single_block(SDHCIState
> *s)
> sdbus_write_data(&s->sdbus, s->fifo_buffer[n]);
> }
> }
> -
> - if (s->trnmod & SDHC_TRNS_BLK_CNT_EN) {
> - s->blkcnt--;
> - }
> + s->blkcnt--;
>
> sdhci_end_transfer(s);
> }
> --
> 2.9.3
>
>
