Simple unions are simpler than flat unions in the schema, but more complicated in C and on the QMP wire: there's extra indirection in C and extra nesting on the wire, both pointless. They're best avoided in new code.
But we can do more: we can flatten the simple unions that aren't used in QMP. In the longer run, I'd love to get rid of simple unions entirely, and reduce the notational overhead of flat unions in the schema. Markus Armbruster (2): numa: Turn simple union NumaOptions into a flat union net: Turn simple union NetLegacyOptions into a flat union net/net.c | 44 ++++++++++++++++++++++---------------------- numa.c | 4 ++-- qapi-schema.json | 17 +++++++++++++++++ 3 files changed, 41 insertions(+), 24 deletions(-) -- 2.7.4