On 02/14/2017 04:25 AM, Markus Armbruster wrote:
> Reorder check_strtox_error() to make it obvious that we always store
> through a non-null @endptr.
>
> Transform
>
> if (some error) {
> error case ...
> err = value for error case;
> } else {
> normal case ...
> err = value for normal case;
> }
> return err;
>
> to
>
> if (some error) {
> error case ...
> return value for error case;
> }
> normal case ...
> return value for normal case;
>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> ---
> util/cutils.c | 89
> ++++++++++++++++++++++++++++++-----------------------------
> 1 file changed, 45 insertions(+), 44 deletions(-)No real net change in lines, but I agree that it is more legible. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
