On Sat, Oct 02, 2010 at 01:02:50PM +0200, Stefan Weil wrote: > Am 30.09.2010 19:12, schrieb Edgar E. Iglesias: > > On Thu, Sep 30, 2010 at 03:15:54PM +0200, Alexander Graf wrote: > >> Edgar E. Iglesias wrote: > >>> v2: > >>> * Address review comments from A. Graf. > >>> > >>> Edgar E. Iglesias (2): > >>> powerpc: Add a ppc-440x5 Xilinx model > >>> powerpc: Add a virtex5 ml507 refdesign board > >>> > >>> Makefile.target | 8 + > >>> default-configs/ppc-softmmu.mak | 2 + > >>> default-configs/ppc64-softmmu.mak | 2 + > >>> default-configs/ppcemb-softmmu.mak | 2 + > >>> hw/virtex_ml507.c | 278 ++++++++++++++++++++++++++++++++++++ > >>> target-ppc/cpu.h | 4 + > >>> target-ppc/translate_init.c | 6 +- > >>> 7 files changed, 300 insertions(+), 2 deletions(-) > >>> create mode 100644 hw/virtex_ml507.c > >>> > >>> > >>> > >> No complaints from me. Feel free to apply them. > >> > >> Signed-off-by: Alexander Graf <ag...@suse.de> > > > > Applied, thanks. > > > > Cheers > > > > > > What about coding conventions? > New source files should comply with CODING_STYLE (block structure). > > virtex_ml507.c: > > + if (!fdt) > + return 0;
Fixed, thanks.