On 17 February 2017 at 15:50, Eric Blake <ebl...@redhat.com> wrote: > On 02/17/2017 09:12 AM, Peter Maydell wrote: >> Unfortunately some older versions of makeinfo don't correctly >> handle the -D command line option and fail to set the variable. >> This then causes them to complain >> docs/qemu-ga-ref.texi:41: warning: undefined flag: VERSION >> >> Work around this by doing as the autotools do, and writing >> the information into a version.texi file which we then >> include from the .texi files that need it. > > Autotools defines a few more macros, but we can always beef up our > version.texi if we find ourselves needing any of them. > >> >> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> >> --- >> Makefile | 17 ++++++++++------- >> docs/qemu-ga-ref.texi | 2 ++ >> docs/qemu-qmp-ref.texi | 2 ++ >> 3 files changed, 14 insertions(+), 7 deletions(-) > > Missing a change to .gitignore for version.texi.
Should be --- a/.gitignore +++ b/.gitignore @@ -107,6 +107,7 @@ docs/qemu-ga-ref.info* docs/qemu-qmp-ref.info* /qemu-ga-qapi.texi /qemu-qapi.texi +/version.texi *.tps .stgit-* cscope.* right? thanks -- PMM
