Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [RFC v6] RBD: Add support readv,writev for rbd
Message-id: 20170221034336.10097-1-jaze...@gmail.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20170221034336.10097-1-jaze...@gmail.com ->
patchew/20170221034336.10097-1-jaze...@gmail.com
Switched to a new branch 'test'
dc83903 RBD: Add support readv,writev for rbd
=== OUTPUT BEGIN ===
Checking PATCH 1/1: RBD: Add support readv,writev for rbd...
ERROR: space required before the open brace '{'
#36: FILE: block/rbd.c:322:
+ if(LIBRBD_USE_IOVEC){
ERROR: space required before the open parenthesis '('
#36: FILE: block/rbd.c:322:
+ if(LIBRBD_USE_IOVEC){
ERROR: trailing whitespace
#69: FILE: block/rbd.c:461:
+ $
ERROR: suspect code indent for conditional statements (4, 9)
#70: FILE: block/rbd.c:462:
+ if(!LIBRBD_USE_IOVEC){
+ if (acb->cmd == RBD_AIO_READ) {
ERROR: space required before the open brace '{'
#70: FILE: block/rbd.c:462:
+ if(!LIBRBD_USE_IOVEC){
ERROR: space required before the open parenthesis '('
#70: FILE: block/rbd.c:462:
+ if(!LIBRBD_USE_IOVEC){
ERROR: suspect code indent for conditional statements (9, 13)
#71: FILE: block/rbd.c:463:
+ if (acb->cmd == RBD_AIO_READ) {
+ qemu_iovec_from_buf(acb->qiov, 0, acb->bounce, acb->qiov->size);
ERROR: space required before the open brace '{'
#102: FILE: block/rbd.c:690:
+ if(!LIBRBD_USE_IOVEC){
ERROR: space required before the open parenthesis '('
#102: FILE: block/rbd.c:690:
+ if(!LIBRBD_USE_IOVEC){
ERROR: space required before the open parenthesis '('
#138: FILE: block/rbd.c:719:
+ if(!LIBRBD_USE_IOVEC)
ERROR: braces {} are necessary for all arms of this statement
#138: FILE: block/rbd.c:719:
+ if(!LIBRBD_USE_IOVEC)
[...]
+ else
[...]
ERROR: space required before the open parenthesis '('
#145: FILE: block/rbd.c:725:
+ if(!LIBRBD_USE_IOVEC)
ERROR: braces {} are necessary for all arms of this statement
#145: FILE: block/rbd.c:725:
+ if(!LIBRBD_USE_IOVEC)
[...]
+ else
[...]
ERROR: space required before the open parenthesis '('
#164: FILE: block/rbd.c:749:
+ if(!LIBRBD_USE_IOVEC)
ERROR: braces {} are necessary for all arms of this statement
#164: FILE: block/rbd.c:749:
+ if(!LIBRBD_USE_IOVEC)
[...]
total: 15 errors, 0 warnings, 146 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
