Hi Eric, Thanks for the long anticipated patch. On 2/21/2017 8:18 AM, Eric Auger wrote: > + DEFINE_PROP_STRING("manufacturer", VFIOPlatformDevice, manufacturer), > + DEFINE_PROP_STRING("model", VFIOPlatformDevice, model),
The OF string is not always of the format "manufacturer, model". HIDMA for instance uses a syntax of "qcom, hidma-1.0" and "qcom, hidma-2.0". This syntax is used for cases where an IP gets used in multiple SOCs. Maybe, we should call it just compatible-string and try not to make meaning out of it. Sinan -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.