On 02/17/2017 02:38 PM, Markus Armbruster wrote: > After a visit of a complex QAPI type FOO > > ov = qobject_output_visitor_new(&foo); > visit_type_FOO(ov, NULL, expr, &error_abort); > visit_complete(ov, &foo); > > we can safely assume qobject_type(foo) is QTYPE_QDICT. We do in many > places, but occasionally assert qobject_type(obj) == QTYPE_QDICT. > Don't. The appropriate place to check such fundamental properties of > QAPI visitors is the test suite. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > block/nbd.c | 2 -- > block/nfs.c | 2 -- > block/qapi.c | 1 - > 3 files changed, 5 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
