Hi, This series seems to have some coding style problems. See output below for more information:
Message-id: 1488145424-14974-1-git-send-email-arm...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v2 00/26] qapi: QMP dispatch and input visitor work === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1488145424-14974-1-git-send-email-arm...@redhat.com -> patchew/1488145424-14974-1-git-send-email-arm...@redhat.com Switched to a new branch 'test' 747d565 qapi: Improve qobject visitor documentation 18a9b51 qapi: Fix object input visit beyond end of list e29e870 tests: Cover input visit beyond end of list 25c2b8f qapi: Make input visitors detect unvisited list tails 6580fd8 test-qobject-input-visitor: Cover missing nested struct member 1323e0f tests: Cover partial input visit of list 150b11a test-string-input-visitor: Improve list coverage 9c47dcb test-string-input-visitor: Tear down existing test automatically 98705bc tests-qobject-input-strict: Merge into test-qobject-input-visitor 192d6b1 qapi: Drop unused non-strict qobject input visitor 2c2ded9 test-qobject-input-visitor: Use strict visitor 51bbde9 qom: Make object_property_set_qobject()'s input visitor strict 1329eb3 qapi: Make string input and opts visitor require non-null input c74a77f qapi: Drop string input visitor method optional() 92e9532 qapi: Improve qobject input visitor error reporting 65f5967 qapi: Make QObject input visitor set *list reliably 2cdf5b0 qapi: Clean up after commit 3d344c2 dd1dfda qapi: Improve a QObject input visitor error message 4f55959 qmp: Improve QMP dispatch error messages 457ec3c qmp: Eliminate silly QERR_QMP_* macros fc5e6da qmp: Drop duplicated QMP command object checks 3498f7b qmp: Clean up how we enforce capability negotiation 93a4cd8 qmp: Dumb down how we run QMP command registration f7cec9b qmp-test: New, covering basic QMP protocol 37ccd76 libqtest: Work around a "QMP wants a newline" bug 181f926 qga: Fix crash on non-dictionary QMP argument === OUTPUT BEGIN === Checking PATCH 1/26: qga: Fix crash on non-dictionary QMP argument... Checking PATCH 2/26: libqtest: Work around a "QMP wants a newline" bug... Checking PATCH 3/26: qmp-test: New, covering basic QMP protocol... Checking PATCH 4/26: qmp: Dumb down how we run QMP command registration... Checking PATCH 5/26: qmp: Clean up how we enforce capability negotiation... Checking PATCH 6/26: qmp: Drop duplicated QMP command object checks... Checking PATCH 7/26: qmp: Eliminate silly QERR_QMP_* macros... Checking PATCH 8/26: qmp: Improve QMP dispatch error messages... Checking PATCH 9/26: qapi: Improve a QObject input visitor error message... Checking PATCH 10/26: qapi: Clean up after commit 3d344c2... Checking PATCH 11/26: qapi: Make QObject input visitor set *list reliably... Checking PATCH 12/26: qapi: Improve qobject input visitor error reporting... Checking PATCH 13/26: qapi: Drop string input visitor method optional()... Checking PATCH 14/26: qapi: Make string input and opts visitor require non-null input... Checking PATCH 15/26: qom: Make object_property_set_qobject()'s input visitor strict... Checking PATCH 16/26: test-qobject-input-visitor: Use strict visitor... Checking PATCH 17/26: qapi: Drop unused non-strict qobject input visitor... Checking PATCH 18/26: tests-qobject-input-strict: Merge into test-qobject-input-visitor... ERROR: line over 90 characters #484: FILE: tests/test-qobject-input-visitor.c:847: + v = visitor_input_test_init(data, "{ 'integer': -42, 'boolean': true, 'string': 'foo', 'extra': 42 }"); ERROR: line over 90 characters #498: FILE: tests/test-qobject-input-visitor.c:861: + v = visitor_input_test_init(data, "{ 'string0': 'string0', 'dict1': { 'string1': 'string1', 'dict2': { 'userdef1': { 'integer': 42, 'string': 'string', 'extra': [42, 23, {'foo':'bar'}] }, 'string2': 'string2'}}}"); ERROR: line over 90 characters #512: FILE: tests/test-qobject-input-visitor.c:875: + v = visitor_input_test_init(data, "[ { 'string': 'string0', 'integer': 42 }, { 'string': 'string1', 'integer': 43 }, { 'string': 'string2', 'integer': 44, 'extra': 'ggg' } ]"); ERROR: line over 90 characters #585: FILE: tests/test-qobject-input-visitor.c:948: + v = visitor_input_test_init(data, "{ 'string': 'c', 'integer': 41, 'boolean': true }"); WARNING: line over 80 characters #592: FILE: tests/test-qobject-input-visitor.c:955: +static void test_visitor_in_fail_union_flat_no_discrim(TestInputVisitorData *data, ERROR: line over 90 characters #600: FILE: tests/test-qobject-input-visitor.c:963: + v = visitor_input_test_init(data, "{ 'integer': 42, 'string': 'c', 'string1': 'd', 'string2': 'e' }"); total: 5 errors, 1 warnings, 233 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 19/26: test-string-input-visitor: Tear down existing test automatically... Checking PATCH 20/26: test-string-input-visitor: Improve list coverage... Checking PATCH 21/26: tests: Cover partial input visit of list... Checking PATCH 22/26: test-qobject-input-visitor: Cover missing nested struct member... Checking PATCH 23/26: qapi: Make input visitors detect unvisited list tails... Checking PATCH 24/26: tests: Cover input visit beyond end of list... ERROR: if this code is redundant consider removing it #84: FILE: tests/test-qobject-input-visitor.c:955: +#if 0 /* FIXME crash */ total: 1 errors, 0 warnings, 95 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 25/26: qapi: Fix object input visit beyond end of list... Checking PATCH 26/26: qapi: Improve qobject visitor documentation... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org