On 02/26/2017 03:43 PM, Markus Armbruster wrote: > The string input visitor tries to cope with null input. Null input > isn't used anywhere, and isn't covered by tests. Unsurprisingly, it > doesn't fully work: start_list() crashes because it passes the input > via parse_str() to strtoll() unchecked. > > Make string_input_visitor_new() assert its argument isn't null, and > drop the code trying to deal with null input. > > The opts visitor crashes when you try to actually visit something with > null input. Make opts_visitor_new() assert its argument isn't null, > mostly for clarity. > > qobject_input_visitor_new() already asserts its argument isn't null. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > qapi/opts-visitor.c | 1 + > qapi/string-input-visitor.c | 54 > ++++++++++++++------------------------------- > 2 files changed, 18 insertions(+), 37 deletions(-) >
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
