On Tue, Feb 28, 2017 at 10:26:49AM -0600, Eric Blake wrote: > On 02/28/2017 10:15 AM, Jeff Cody wrote: > > This adds support for three additional options that may be specified > > by QAPI in blockdev-add: > > > > server: host, port > > auth method: either 'cephx' or 'none' > > > > The "server" and "auth-supported" QAPI parameters are arrays. To conform > > with the rados API, the array items are join as a single string with a ';' > > character as a delimiter when setting the configuration values. > > > > Reviewed-by: Markus Armbruster <arm...@redhat.com> > > What happened to Signed-off-by? You'll have to resubmit the pull request >
Argh, thanks - that is what happens when I go outside my normal workflow. Will send a v2 pr > > --- > > block/rbd.c | 134 > > +++++++++++++++++++++++++++++++++++++++++++++++++++ > > qapi/block-core.json | 29 +++++++++++ > > 2 files changed, 163 insertions(+) > > > > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >
