On Wed, Mar 01, 2017 at 09:50:38AM -0500, Stefan Berger wrote: > I had already proposed a linked-in version before I went to the out-of-process > design. Anthony's concerns back then were related to the code not being > trusted > and a segfault in the code could bring down all of QEMU. That we have test > suites running over it didn't work as an argument. Some of the test suite are > private, though.
Given how bad the alternative is maybe we should go back to that one. Same argument can be made for any device and we aren't making them out of process right now. IIMO it's less the in-process question (modularization of QEMU has been on the agenda since years and I don't think anyone is against it) it's more a code control/community question. It doesn't look like userspace swtpm bits have a large community of developers around it, and the only user appears to be QEMU, so depending on that externally does not make sense, we should just have them in-tree. This way we don't need to worry about versioning etc. -- MST