On 02/03/2017 16:55, Halil Pasic wrote: >>>> blk_set_aio_context(s->conf->conf.blk, qemu_get_aio_context()); > I'm wondering if synchronization is needed for batch_notify_vqs. I think > the set_bit can be from the iothread, but the notify_guest_bh below is main > event loop. Is it OK like this (could we miss bits set in other thread)? > Does blk_set_aio_context include a barrier?
Another good question---yes, it does (via bdrv_set_aio_context's call to aio_context_acquire). But it's something to remember for when I get round to removing aio_context_acquire! Paolo
