On 10/11/2010 11:03 AM, Markus Armbruster wrote:
As noted before, this is an incompatible change of the human monitor command: unit now defaults to 'M'. This must be noted*prominently* in the commit message. Best in the subject.Incompatible changes can break tools. Quick grep of libvirt: src/qemu/qemu_monitor_json.c: cmd = qemuMonitorJSONMakeCommand("migrate_set_speed", src/qemu/qemu_monitor_text.c: if (virAsprintf(&cmd, "migrate_set_speed %lum", bandwidth)< 0) { Looks like we're safe here. Anthony, is this incompatibility okay? Help should be updated in the same patch; please squash 6/7 into 5/7.
Personally, I'd rather see the patch I sent incorporated, so that there is no change in the monitor at all.
Not going to make a fuss of it as long as libvirt is okay, though. Paolo
