On 03/03/2017 01:37 PM, Markus Armbruster wrote: > Eric Blake <ebl...@redhat.com> writes: > >> On 03/03/2017 06:32 AM, Markus Armbruster wrote: >>> The command registry encapsulates a single command list. Give the >>> functions using it a parameter instead. Define suitable command lists >>> in monitor, guest agent and test-qmp-commands. >>>
>> ...or is this leftovers from your debugging? > > Corret. I'll drop it. > >> The rest of the patch looks fine; it is converting a global variable >> into a per-instance variable. > > Squashing in the obvious garbage collection. May I add your R-by? > Yes, with that squashed in, Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature