Re: [Qemu-devel] [PATCH] 9pfs: fail local_statfs() earlier

[Philippe Mathieu-Daudé]

On 03/03/2017 03:03 PM, Greg Kurz wrote:

If we cannot open the given path, we can return right away instead of
passing -1 to fstatfs() and close(). This will make Coverity happy.

(Coverity issue CID1371729)

Signed-off-by: Greg Kurz <gr...@kaod.org>

Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>

---
 hw/9pfs/9p-local.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
index fe930300445a..ea9a1ced0394 100644
--- a/hw/9pfs/9p-local.c
+++ b/hw/9pfs/9p-local.c
@@ -1053,6 +1053,9 @@ static int local_statfs(FsContext *s, V9fsPath *fs_path, 
struct statfs *stbuf)
     int fd, ret;

     fd = local_open_nofollow(s, fs_path->data, O_RDONLY, 0);
+    if (fd == -1) {
+        return -1;
+    }
     ret = fstatfs(fd, stbuf);
     close_preserve_errno(fd);
     return ret;