On 03/07/2017 07:36 PM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilb...@redhat.com>
>
> Provide a helper to say whether a RAMBlock was created as a
> shared mapping.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
> ---
> exec.c | 5 +++++
> include/exec/cpu-common.h | 1 +
> 2 files changed, 6 insertions(+)
>
> diff --git a/exec.c b/exec.c
> index aabb035..c2cc455 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1560,6 +1560,11 @@ const char *qemu_ram_get_idstr(RAMBlock *rb)
> return rb->idstr;
> }
>
> +bool qemu_ram_is_shared(RAMBlock *rb)
> +{
> + return rb->flags & RAM_SHARED;
Hm, it appears to me RAM_SHARED is defined conditionally, that's within
#if !defined(CONFIG_USER_ONLY)
#endif
The function however seems to be defined and using RAM_SHARED
unconditionally. Either one or the other seems inappropriate to me.
Regards,
Halil
