On Fri, Mar 03, 2017 at 11:56:54PM +0200, Nir Soffer wrote:
> On Fri, Mar 3, 2017 at 3:51 PM, Stefan Hajnoczi <stefa...@redhat.com> wrote:
> > + ret_size = bdrv_max_size(drv, opts, in_blk ? blk_bs(in_blk) : NULL,
> > + &local_err);
> > + if (local_err) {
> > + error_report_err(local_err);
> > + goto fail;
> > + }
> > +
> > + if (output_format == OFORMAT_HUMAN) {
> > + printf("%" PRIu64 "\n", ret_size);
> > + } else {
> > + printf("{ \"size\": %" PRIu64 " }\n", ret_size);
> > + }
> > +
> > + ret = 0;
> > +
> > +fail:
>
> This looks more like out: to me, since we use it both for normal
> and abnormal flows.Looking at the source file there is no consistency: "err", "fail", "out" are all used in various places. I'm happy to switch this to "out", but for the record, I find "fail" clearer since it communicates the intention that this is an error return. Will fix.
signature.asc
Description: PGP signature
