On Wed, Mar 15, 2017 at 12:34:21PM +0000, Daniel P. Berrange wrote: > The build rules for trace files have a dependancy on $(tracetool-y). > This variable populated in the trace/Makefile.objs file and thus its > definition gets pulled into the top level makefile. This happens too > late in the process though, so by the time $(tracetool-y) is defined, > make has already evaluated $(tracetool-y) in the dependancies and > found it to be empty. The result is that when the tracetool source > is changed, the generated files are not rebuilt. The solution is to > define the variable in the top level makefile too > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > Makefile | 3 +++ > trace/Makefile.objs | 8 -------- > 2 files changed, 3 insertions(+), 8 deletions(-)
Thanks, applied to my tracing tree: https://github.com/stefanha/qemu/commits/tracing Stefan
signature.asc
Description: PGP signature
