On Fri, 17 Mar 2017 03:45:56 -0700 (PDT) no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Message-id: 148974701986.29545.5414999102981738774.stgit@bahia > Subject: [Qemu-devel] [PATCH] checkpatch: allow longer lines for logging > functions > Type: series > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > # Useful git options > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; > then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > * [new tag] > patchew/148974701986.29545.5414999102981738774.stgit@bahia -> > patchew/148974701986.29545.5414999102981738774.stgit@bahia > * [new tag] > patchew/148974744281.30636.17973264008285415592.stgit@bahia -> > patchew/148974744281.30636.17973264008285415592.stgit@bahia > Switched to a new branch 'test' > 390d7c4 checkpatch: allow longer lines for logging functions > > === OUTPUT BEGIN === > Checking PATCH 1/1: checkpatch: allow longer lines for logging functions... > ERROR: line over 90 characters
Ha ha ! Should checkpatch allow long regexp lines in itself ? ;) > #38: FILE: scripts/checkpatch.pl:1349: > + !($line =~ > /^\+\s*$logFunctions\s*\(\s*(?:([^"]*))?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ || > > total: 1 errors, 0 warnings, 20 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-de...@freelists.org
pgp2tH0mj8iPN.pgp
Description: OpenPGP digital signature
