On Wed, Oct 13, 2010 at 7:19 AM, Markus Armbruster <arm...@redhat.com> wrote:
> Blue Swirl <blauwir...@gmail.com> writes:
>
>> On Mon, Oct 11, 2010 at 12:52 PM, Markus Armbruster <arm...@redhat.com>
>> wrote:
>>> Warns about this line in check-qjson.c:
>>> QObject *obj = qobject_from_json("");
>>>
>>> The obvious fix (add -Wno-format-zero-length to gcc_flags) doesn't
>>> work, because -Wall switches it on again. Fix by putting configured
>>> flags last.
>>
>> This would disable the flag globally. I'd rather disable the flag only
>> for check-qjson.o
>
> Is this warning worth the hassle? What's the problem with empty format
> strings?
Your fix solves this specific case, but it also degrades the gcc
checks of the mainstream code (slightly). I think the test suite need
not follow the level of checking that should be applied to mainstream,
or at least the warnings there should not be fatal.
>> or more generically, remove -Werror for checks. For
>> example, there could be a check for how we handle invalid formats and
>> then the sources would contain format strings that annoy GCC, but we
>> wouldn't want warnings from that to stop the build.
>
> If you want to go that extra mile, feel free. For me, --disable-werror
> has been good enough.
In that case, we could ignore the warning, since the only reporter is
able to use a workaround ;-).
> Regardless, I think we need the second patch hunk, to prevent -Wall from
> trampling over $gcc_flags.
I'm fine with that part.
