On 01/30/2017 02:15 PM, Stefan Weil wrote: > Returning NULL from get_max_cpu_model results in a SIGSEGV runtime error. > > Signed-off-by: Stefan Weil <s...@weilnetz.de> > --- > > v2: Re-sent as v1 was damaged by my mailer. > > This is also broken in Debian. > > In addition, there is no default CPU ("any"), so binfmt and related > actions currently don't work. I hacked my local installation by > duplicating the "qemu" cpu definition for "any", but maybe there is > a better solution.
applied to our tree. Do we need cc stable as well? > > Regards > Stefan > > target/s390x/cpu_models.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c > index 2a894ee..6e34763 100644 > --- a/target/s390x/cpu_models.c > +++ b/target/s390x/cpu_models.c > @@ -660,7 +660,6 @@ static void check_compatibility(const S390CPUModel > *max_model, > > static S390CPUModel *get_max_cpu_model(Error **errp) > { > -#ifndef CONFIG_USER_ONLY > static S390CPUModel max_model; > static bool cached; > > @@ -680,7 +679,6 @@ static S390CPUModel *get_max_cpu_model(Error **errp) > cached = true; > return &max_model; > } > -#endif > return NULL; > } >