On 03/22/2017 04:00 PM, Kevin Wolf wrote: > Success for bdrv_flush() means that all previously written data is safe > on disk. For fdatasync(), the best semantics we can hope for on Linux > (without O_DIRECT) is that all data that was written since the last call > was successfully written back. Therefore, and because we can't redo all > writes after a flush failure, we have to give up after a single > fdatasync() failure. After this failure, we would never be able to make > the promise that a successful bdrv_flush() makes. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block/file-posix.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+)
Makes sense for 2.9 (it doesn't change the data loss, but alerts to the user to the knowledge of data loss a lot sooner, perhaps before things get even worse). Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
