On 03/22/2017 08:32 AM, Igor Mammedov wrote: > if board supports CpuInstanceProperties, report them for > each CPU thread listed. Main motivation for this is to > provide these properties introspection via QMP interface > for using in test cases to verify numa node to cpu mapping, > which includes not only boards that support cpu hotplug > and have this info in query-hotpluggable-cpus (pc/spapr) > but also for boards that don't not support hotpluggable-cpus > but support numa mapping (virt-arm). > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > ---
> @@ -1860,6 +1863,12 @@ CpuInfoList *qmp_query_cpus(Error **errp) > #else > info->value->arch = CPU_INFO_ARCH_OTHER; > #endif > + if ((info->value->has_props = !!mc->cpu_index_to_instance_props)) { checkpatch.pl doesn't flag that? We generally try to avoid side-effects inside conditionals. > + CpuInstanceProperties *props; > + props = g_malloc0(sizeof(*props)); > + *props = mc->cpu_index_to_instance_props(ms, cpu->cpu_index); > + info->value->props = props; Why two spaces after =? With those cleaned up, Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature