On 03/24/2017 09:10 AM, Jeff Cody wrote: > On Fri, Mar 24, 2017 at 08:49:20AM -0500, Eric Blake wrote: >> On 03/24/2017 07:42 AM, Jeff Cody wrote: >> >>> Agree. My preference is to leave it as an array of methods, so long as that >>> is tenable to libvirt. >> >> The -drive syntax should remain unchanged (that's an absolute must for >> libvirt). But the QMP syntax being an array of methods sounds best to >> me, and I think password-secret should be part of the array. So my vote >> would be for: >> >> { "driver": "rbd", "image": "foo", >> "auth": [ { "type": "cephx", "password-secret": "sec0" }, >> { "type": "none" } ], >> "pool": "bar" } >> >> It makes mapping -drive arguments into QMP form a bit trickier, but the >> QMP form is then easily extensible if we add another auth method down >> the road. >> > > In that case, what about adding user as well, and not just password-secret?
Makes sense - anything that is associated solely with cephx should belong to the same flat-union branch for cephx, rather than at the top level. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature