On Fri, Mar 31, 2017 at 5:46 PM, Eduardo Habkost <ehabk...@redhat.com> wrote:
> generic-sdhci needs to be wired by other devices' code, so it
> can't be used with -device. Remove the user_creatable flag from
> the device class.
>
> Cc: Peter Maydell <peter.mayd...@linaro.org>
> Cc: "Edgar E. Iglesias" <edgar.igles...@gmail.com>
> Cc: David Gibson <da...@gibson.dropbear.id.au>
> Cc: Alexander Graf <ag...@suse.de>
> Cc: "Michael S. Tsirkin" <m...@redhat.com>
> Cc: Marcel Apfelbaum <mar...@redhat.com>
> Cc: Prasad J Pandit <p...@fedoraproject.org>
> Cc: Alistair Francis <alistair.fran...@xilinx.com>
> Signed-off-by: Eduardo Habkost <ehabk...@redhat.com>
Reviewed-by: Alistair Francis <alistair.fran...@xilinx.com>
Thanks,
Alistair
> ---
> hw/sd/sdhci.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
> index 186555188b..6d6a791ee9 100644
> --- a/hw/sd/sdhci.c
> +++ b/hw/sd/sdhci.c
> @@ -1360,11 +1360,6 @@ static void sdhci_sysbus_class_init(ObjectClass
> *klass, void *data)
> dc->props = sdhci_sysbus_properties;
> dc->realize = sdhci_sysbus_realize;
> dc->reset = sdhci_poweron_reset;
> - /*
> - * FIXME: Set only for compatibility on q35 machine-type.
> - * Probably never meant to be user-creatable
> - */
> - dc->user_creatable = true;
> }
>
> static const TypeInfo sdhci_sysbus_info = {
> --
> 2.11.0.259.g40922b1
>
>
