On 04.04.2017 22:24, Eduardo Habkost wrote: > kvmclock should be used by guests only when the appropriate CPUID > feature flags are set on the VCPU, and it is automatically > created by kvmclock_create() when those feature flags are set. > This means creating a kvmclock device using -device is useless. > Remove user_creatable from its device class.
Actually, I think this device should not be a sysbus device at all, should it? It does not have any IO, GPIO or IRQ lines, so sysbus does not make sense here, it should be of type TYPE_DEVICE instead. Anyway, that's another topic. For your patch: Reviewed-by: Thomas Huth <th...@redhat.com>
