On 04/06/2017 07:52 AM, Eric Blake wrote: >>> +out: >>> + QDECREF(snapshot_options); >>> g_free(tmp_filename); >>> return bs_snapshot; >> >> bs_snapshot is uninitialised or at least the wrong return value in error >> cases. (Hm... Shouldn't the compiler catch the uninitialised part?) > > Odd, and I agree that I recall the compiler generally able to catch that > (maybe it's a matter of compiling with -g vs. -O2). I'm surprised the > autobuilder didn't flag it.
And now the autobuilder finally replies. It is indeed a matter of difference in CFLAGS on whether the compiler will catch it. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
