On 04/12/2017 01:52 AM, Markus Armbruster wrote: > Eric Blake <ebl...@redhat.com> writes: > >> We now have macros in place to make it less verbose to add a scalar >> to QDict and QList, so use them. >> >> Patch created mechanically via: >> spatch --sp-file scripts/coccinelle/qobject.cocci \ >> --macro-file scripts/cocci-macro-file.h --dir block --in-place >> then touched up manually to fix a couple of '?:' back to original spacing. >> >> For ease of review, the mechanical work was split by tree location: >> this only touches files under block/; there are other block-related >> files (like top-level block.c) that will be fixed in a later global >> cleanup. > > I don't like this split. Splitting out *subsystems* may ease review, > but this splits out directory block/, which is only a part of the block > subsystem. Explaining this takes you more than three dozen words. I'd > prefer either the whole block subsystem (as defined in MAINTAINERS) > split out, or no split. > > I'm willing to accept the split as is anyway if block maintainers are > okay with it. > > I'm also willing to squash the three parts on commit.
I'm leaning towards squashing the three into one. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
