On 05.04.2017 17:35, Eric Blake wrote: > On 04/05/2017 10:18 AM, Denis V. Lunev wrote: >> From: Klim Kireev <pro...@virtuozzo.mipt.ru> > > s/mitakes/mistakes/ in the subject > > A blank commit message body doesn't help - the subject says what was > changed but not why (for example, output of checkpatch.pl without the > patch applied); and details may help in grepping past history when > looking for the change or even to justify that the change is not just churn. > >> >> Signed-off-by: Klim Kireev <pro...@virtuozzo.mipt.ru> >> Signed-off-by: Denis V. Lunev <d...@openvz.org> >> CC: Kevin Wolf <kw...@redhat.com> >> CC: Max Reitz <mre...@redhat.com> >> --- >> include/block/block_int.h | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> > > At any rate, all of the changes (the fact that we prefer binding the > pointer operator * to the name on the right rather than the type on the > left) look sane.
I know someone who disagrees but that someone also knows that I will support and accept this kind of patches gladly. O:-) Max > Reviewed-by: Eric Blake <ebl...@redhat.com>
signature.asc
Description: OpenPGP digital signature
