Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: 20170401155751.14322-1-mre...@redhat.com Subject: [Qemu-devel] [RFC for-3.0 0/4] block: Add qcow2-rust block driver === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20170401155751.14322-1-mre...@redhat.com -> patchew/20170401155751.14322-1-mre...@redhat.com - [tag update] patchew/20170418075911.7579-1-f...@redhat.com -> patchew/20170418075911.7579-1-f...@redhat.com Switched to a new branch 'test' f29e573 block/qcow2-rust: Register block driver 5fb5514 block/qcow2-rust: Add partial write support a349cfd block/qcow2-rust: Add qcow2-rust block driver 430d32b block: Add Rust interface === OUTPUT BEGIN === Checking PATCH 1/4: block: Add Rust interface... Checking PATCH 2/4: block/qcow2-rust: Add qcow2-rust block driver... Checking PATCH 3/4: block/qcow2-rust: Add partial write support... Checking PATCH 4/4: block/qcow2-rust: Register block driver... ERROR: open brace '{' following function declarations go on the next line #63: FILE: block/qcow2-rust.c:31: +static BlockDriver _ __attribute__((used)) = { ERROR: externs should be avoided in .c files #68: FILE: block/qcow2-rust.c:36: +extern void bdrv_qcow2_rust_init(void); total: 2 errors, 0 warnings, 45 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org