On Tue, Apr 18, 2017 at 01:44:43PM -0500, Eric Blake wrote: > On 04/18/2017 12:45 PM, Jeff Cody wrote: > > For the tests that use the common.qemu functions for running a QEMU > > process, _cleanup_qemu must be called in the exit function. > > > > If it is not, if the qemu process aborts, then not all of the droppings > > are cleaned up (e.g. pidfile, fifos). > > > > This updates those tests that did not have a cleanup in qemu-iotests. > > > > (I swapped spaces for tabs in test 102 as well) > > > > Reported-by: Eric Blake <ebl...@redhat.com> > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > Signed-off-by: Jeff Cody <jc...@redhat.com> > > --- > > > > v2 fixed typo in test 094, s/cleanup/_cleanup/ for the trap function. > > > > tests/qemu-iotests/028 | 1 + > > tests/qemu-iotests/094 | 11 ++++++++--- > > tests/qemu-iotests/102 | 5 +++-- > > tests/qemu-iotests/109 | 1 + > > tests/qemu-iotests/117 | 1 + > > tests/qemu-iotests/130 | 1 + > > tests/qemu-iotests/140 | 1 + > > tests/qemu-iotests/141 | 1 + > > tests/qemu-iotests/143 | 1 + > > 9 files changed, 18 insertions(+), 5 deletions(-) > > Looks like you missed (at least?) 063 >
I did miss 156. But unless I am missing something, 063 does not use common.qemu... (I'll send a v3 with 156) -Jeff