"Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> We have change in the previous patch to use migration capabilities for
>> it. Notice that we continue using the old command line flags from
>> migrate command from the time being. Remove the set_params method as
>> now it is empty.
>>
>> Signed-off-by: Juan Quintela <quint...@redhat.com>
>> ---
>> include/migration/migration.h | 2 --
>> migration/block.c | 17 ++---------------
>> migration/colo.c | 3 ---
>> migration/migration.c | 8 +++++---
>> migration/savevm.c | 2 --
>> 5 files changed, 7 insertions(+), 25 deletions(-)
>>
>> diff --git a/include/migration/migration.h b/include/migration/migration.h
>> index 5c78ae1..09d3188 100644
>> --- a/include/migration/migration.h
>> +++ b/include/migration/migration.h
>> @@ -41,8 +41,6 @@
>> extern int only_migratable;
>>
>> struct MigrationParams {
>> - bool blk;
>> - bool shared;
>> };
>
> I'm not sure that's portable C - some suggests that empty struct's
> are a GNU addition.
> I suggest either leaving them here, or merging this with the next
> patch.
Added an unused bool. I think it is clearer in two patches.
Thanks, Juan.
