On Wed, Apr 19, 2017 at 18:27 Fam Zheng <f...@redhat.com> wrote: > On Sat, 04/01 20:14, Ashijeet Acharya wrote: > > Rename the existing get_cluster_offset() function to > > vmdk_get_cluster_offset() and have it make use of the new > > get_cluster_table() to load the cluster tables. Also, it is no longer > > used to allocate new clusters and hence perform COW. Make the necessary > > renames at all the occurrences of get_cluster_offset(). > > > > Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> > > --- > > block/vmdk.c | 117 > +++++++++++------------------------------------------------ > > 1 file changed, 21 insertions(+), 96 deletions(-) > > This is definitely more than a function rename, like I said in reply to > patch 3, > it could probably be split to smaller ones (rename, and others, for > example), > and reordered to make reviewing easier.
Maybe, because I have also refactored it to have vmdk_get_cluster_offset() make use of the get_cluster_table() (and friends) to avoid duplication. I will try to split it as 1. Rename 2. Refactor it to make use of get_cluster_table() by moving that out of patch 3 as of now. Will that work? I think this will also keep the compiler happy while reviewing. Ashijeet
