Thank you for detailed review.
On Wed, Oct 20, 2010 at 11:56:16AM +0200, Michael S. Tsirkin wrote:
> > +static uint32_t aer_log_del(PCIEAERLog *aer_log)
> > +{
> > + uint32_t i = aer_log->consumer;
> > + aer_log->consumer = aer_log_next(aer_log->consumer, aer_log->log_max);
> > + return i;
> > +}
>
>
> Please just use 'int' or 'unsigned' instead of uint32_t if you simply
> want to say 'a number'. Using specific length makes it impossible to
> say where you *really* want a value.
PCIEAERLog is saved/loaded. So explicit sized number is chosen.
--
yamahata
