"Dr. David Alan Gilbert" <dgilb...@redhat.com> wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> --- >> include/migration/migration.h | 8 -------- >> include/migration/socket.h | 25 +++++++++++++++++++++++++ >> migration/migration.c | 1 + >> migration/socket.c | 1 + >> 4 files changed, 27 insertions(+), 8 deletions(-) >> create mode 100644 include/migration/socket.h >> >> diff --git a/include/migration/migration.h b/include/migration/migration.h >> index 077b75b..0c6dae5 100644 >> --- a/include/migration/migration.h >> +++ b/include/migration/migration.h >> @@ -194,14 +194,6 @@ void migration_tls_channel_connect(MigrationState *s, >> >> uint64_t migrate_max_downtime(void); >> >> -void tcp_start_incoming_migration(const char *host_port, Error **errp); >> - >> -void tcp_start_outgoing_migration(MigrationState *s, const char >> *host_port, Error **errp); >> - >> -void unix_start_incoming_migration(const char *path, Error **errp); >> - >> -void unix_start_outgoing_migration(MigrationState *s, const char >> *path, Error **errp); >> - >> void rdma_start_outgoing_migration(void *opaque, const char >> *host_port, Error **errp); >> >> void rdma_start_incoming_migration(const char *host_port, Error **errp); > > Have you considered a header with just the transports in it? > > There doesn't seem to be that much point with one with just the > rdma's in, and one iwth just the tcp's in etc.
In the future, the transports should be using module_type() and no need of this stuff at all. It should make easier to compile transports out (famous last words). Later, Juan.
