Hailiang Zhang <zhang.zhanghaili...@huawei.com> wrote:
> On 2017/4/26 15:32, Juan Quintela wrote:
>> Both the ram bitmap and the unsent bitmap are split by RAMBlock.
>>
>> Signed-off-by: Juan Quintela <quint...@redhat.com>
>>
>> --
>>
>> Fix compilation when DEBUG_POSTCOPY is enabled (thanks Hailiang)
>>
>> Signed-off-by: Juan Quintela <quint...@redhat.com>
>> + postcopy_chunk_hostpages_pass(ms, false, block, pds);
>> +
>> + postcopy_discard_send_finish(ms, pds);
>> return 0;
>
> It always return 0 here for postcopy_chunk_hostpages(), so change it to void ?
This was dave code. I assume that he has in mind something where it can
fail?
>> + /* Deal with TPS != HPS and huge pages */
>> + ret = postcopy_chunk_hostpages(ms, block);
>> + if (ret) {
>
> It will never go here, see above.
Yeap, I also noticed.
>> + bitmap_or(unsentmap, unsentmap, bitmap, pages);
>> #ifdef DEBUG_POSTCOPY
>> - ram_debug_dump_bitmap(unsentmap, true);
>> + ram_debug_dump_bitmap(unsentmap, true, pages);
> Indent, you use tab here.
Fixed.
> Others look good to me.
>
> Reviewed-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
Thanks.
