Hi, This series seems to have some coding style problems. See output below for more information:
Subject: [Qemu-devel] [PATCH v5 00/19] TCG cross-tb optimizations Message-id: 20170427120006.20564-1-...@twiddle.net Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' dd00ff3 tcg/s390: Implement goto_ptr 7a3bb3b tcg/sparc: Implement goto_ptr d0faf3d tcg/aarch64: Implement goto_ptr 3e4a3c8 tcg/ppc: Implement goto_ptr 4203286 tcg/i386: implement goto_ptr 1ab1bc0 target/alpha: Use tcg_gen_goto_ptr aa74c2b tb-hash: improve tb_jmp_cache hash function in user mode 623c464 target/i386: optimize indirect branches 8265f15 target/i386: optimize cross-page direct jumps in softmmu e57b419 target/i386: introduce gen_jr helper to generate lookup_and_goto_ptr f6f46f5 target/arm: optimize indirect branches e3a959e target/arm: optimize cross-page direct jumps in softmmu 580b0ef tcg: export tcg_gen_lookup_and_goto_ptr 12ab749 tcg: introduce goto_ptr opcode 0bbf965 tcg-runtime: add lookup_tb_ptr helper 6e2d49c exec-all: export tb_htable_lookup b0be14c qemu/atomic: Loosen restrictions for 64-bit ILP32 hosts 99bd77b tcg/sparc: Use the proper compilation flags for 32-bit f0e5c62 target/nios2: Fix 64-bit ilp32 compilation === OUTPUT BEGIN === Checking PATCH 1/19: target/nios2: Fix 64-bit ilp32 compilation... Checking PATCH 2/19: tcg/sparc: Use the proper compilation flags for 32-bit... Checking PATCH 3/19: qemu/atomic: Loosen restrictions for 64-bit ILP32 hosts... WARNING: architecture specific defines should be avoided #33: FILE: include/qemu/atomic.h:104: +#if defined(__x86_64__) || defined(__sparc__) total: 0 errors, 1 warnings, 87 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/19: exec-all: export tb_htable_lookup... Checking PATCH 5/19: tcg-runtime: add lookup_tb_ptr helper... Checking PATCH 6/19: tcg: introduce goto_ptr opcode... Checking PATCH 7/19: tcg: export tcg_gen_lookup_and_goto_ptr... Checking PATCH 8/19: target/arm: optimize cross-page direct jumps in softmmu... Checking PATCH 9/19: target/arm: optimize indirect branches... Checking PATCH 10/19: target/i386: introduce gen_jr helper to generate lookup_and_goto_ptr... Checking PATCH 11/19: target/i386: optimize cross-page direct jumps in softmmu... Checking PATCH 12/19: target/i386: optimize indirect branches... Checking PATCH 13/19: tb-hash: improve tb_jmp_cache hash function in user mode... Checking PATCH 14/19: target/alpha: Use tcg_gen_goto_ptr... ERROR: return is not a function, parentheses are not required #31: FILE: target/alpha/translate.c:465: + return ((ctx->tb->cflags & CF_LAST_IO) total: 1 errors, 0 warnings, 113 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 15/19: tcg/i386: implement goto_ptr... Checking PATCH 16/19: tcg/ppc: Implement goto_ptr... Checking PATCH 17/19: tcg/aarch64: Implement goto_ptr... Checking PATCH 18/19: tcg/sparc: Implement goto_ptr... Checking PATCH 19/19: tcg/s390: Implement goto_ptr... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org